Re: [PATCH 1/3] Enable non page boundary BAR device assignment

Chris Wright
2009-12-16T05:47:14Z

* Alexander Graf (agraf@suse.de) wrote:
> Michael S. Tsirkin wrote:
> > Existing code first page aligned address, passes this to mmap,

Did you mean page aligned size?

> > then adds page offset. I do not know why. Could be e.g. to handle
> > different libc/kernel versions. If we are not sure it is
> > not needed, let's keep it this way. If we are sure, let's
> > cleanup in a separate patch. Makes sense?
>
> Chris, want to make a statement here? :-)

I have no issue w/ splitting that out. I don't think it is necessary.
The "adds page offset" bit is, however.

thanks,
-chris