Re: [PATCH 1/3] Enable non page boundary BAR device assignment

Michael S. Tsirkin
2009-12-16T10:44:33Z

On Tue, Dec 15, 2009 at 09:47:09PM -0800, Chris Wright wrote:
> * Alexander Graf (agraf@suse.de) wrote:
> > Michael S. Tsirkin wrote:
> > > Existing code first page aligned address, passes this to mmap,
>
> Did you mean page aligned size?

Yes, of course.

> > > then adds page offset. I do not know why. Could be e.g. to handle
> > > different libc/kernel versions. If we are not sure it is
> > > not needed, let's keep it this way. If we are sure, let's
> > > cleanup in a separate patch. Makes sense?
> >
> > Chris, want to make a statement here? :-)
>
> I have no issue w/ splitting that out. I don't think it is necessary.
> The "adds page offset" bit is, however.
>
> thanks,
> -chris

I looked at kernel source history, as far as I can tell
all mmap implementations round size up to full page size.
So yes, this seems safe.

--
MST