From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] slow_map: minor improvements to ROM BAR handling Date: Tue, 22 Dec 2009 17:28:06 +0200 Message-ID: <20091222152806.GA18676@redhat.com> References: <20091222111044.GA16000@redhat.com> <4B30B603.8080707@suse.de> <20091222124311.GD16165@redhat.com> <4B30CAF2.4040409@suse.de> <20091222151911.GC18541@redhat.com> <4B30E470.2030001@redhat.com> <4B30E4BB.8000507@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46224 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbZLVPay (ORCPT ); Tue, 22 Dec 2009 10:30:54 -0500 Content-Disposition: inline In-Reply-To: <4B30E4BB.8000507@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Dec 22, 2009 at 04:24:43PM +0100, Alexander Graf wrote: > Avi Kivity wrote: > > On 12/22/2009 05:19 PM, Michael S. Tsirkin wrote: > >> > >>> I'm not sure the BIOS is the only one executing ROMs. If it is, then > >>> I'm > >>> good with the change. > >>> Maybe it'd make sense to also add a read only flag so we don't > >>> accidently try to write to the ROM region with slow_map. > >>> > >>> Alex > >>> > >> Correct: I think it's made readonly down the road with mprotect, > >> so attempt to do so will crash qemu :) > >> > > > > Alex, are you happy with this? I'd like to apply it. > > I'd like to see the read-only protection in. Yes, this is a must, I am working on it. > Apart from that I'm good on checking it in, though I'm only awaiting > the day someone runs code off such a ROM region ;-). > > Alex Is there a way to trap this and fprintf something? -- MST