public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Alexander Graf <agraf@suse.de>,
	Chris Wright <chrisw@sous-sol.org>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Dmitri Seletski <drjoms@gmail.com>
Subject: Re: [PATCH qemu-kvm] device assignment: default requires IOMMU
Date: Thu, 24 Dec 2009 18:41:00 +1100	[thread overview]
Message-ID: <20091224074100.GF2814@verge.net.au> (raw)
In-Reply-To: <200912241456.00624.sheng@linux.intel.com>

On Thu, Dec 24, 2009 at 02:56:00PM +0800, Sheng Yang wrote:
> On Thursday 24 December 2009 14:51:23 Simon Horman wrote:
> > On Thu, Dec 24, 2009 at 01:45:34AM +0100, Alexander Graf wrote:
> > > Am 23.12.2009 um 23:40 schrieb Chris Wright <chrisw@sous-sol.org>:
> > > >[ resend, fixing email header, sorry for duplicate ]
> > > >
> > > >The default mode for device assignment is to rely on an IOMMU for
> > > >proper translations and a functioning device in the guest.  The
> > > >current
> > > >logic makes this requirement advisory, and simply disables the request
> > > >for IOMMU if one is not found on the host.  This makes for a confused
> > > >user when the device assignment appears to work, but the device in the
> > > >guest is not functioning  (I've seen about a half-dozen reports with
> > > >this failure mode).
> > > >
> > > >Change the logic such that the default requires the IOMMU.  Period.
> > > >If the host does not have an IOMMU, device assignment will fail.
> > > >
> > > >This is a user visible change, however I think the current
> > > >situation is
> > > >simply broken.
> > > >
> > > >And, of course, disabling the IOMMU requirement using the old:
> > > >
> > > >  -pcidevice host=[addr],dma=none
> > > >
> > > >or the newer:
> > > >
> > > >  -device pci-assign,host=[addr],iommu=0
> > > >
> > > >will do what it always did (not require an IOMMU, and fail to work
> > > >properly).
> > >
> > > Yay!
> > 
> > Sounds good to me. Though I am curious to know the reasoning
> > behind the current logic.
> > 
> Sounds pretty good. :)
> 
> I think maybe it due to we are interested in implementing PV DMA?

Ok, that would explain it.


  parent reply	other threads:[~2009-12-24  7:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 22:40 [PATCH qemu-kvm] device assignment: default requires IOMMU Chris Wright
2009-12-24  0:45 ` Alexander Graf
2009-12-24  6:51   ` Simon Horman
2009-12-24  6:56     ` Sheng Yang
2009-12-24  7:37       ` Muli Ben-Yehuda
2009-12-24  7:41       ` Simon Horman [this message]
2009-12-24 11:35 ` Marcelo Tosatti
2010-01-18 14:18 ` Alexander Graf
2010-01-18 14:20   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091224074100.GF2814@verge.net.au \
    --to=horms@verge.net.au \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=chrisw@sous-sol.org \
    --cc=drjoms@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox