From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix race between APIC TMR and IRR
Date: Tue, 29 Dec 2009 20:09:39 -0200 [thread overview]
Message-ID: <20091229220939.GA17127@amt.cnet> (raw)
In-Reply-To: <1262083336-5491-1-git-send-email-avi@redhat.com>
On Tue, Dec 29, 2009 at 12:42:16PM +0200, Avi Kivity wrote:
> When we queue an interrupt to the local apic, we set the IRR before the TMR.
> The vcpu can pick up the IRR and inject the interrupt before setting the TMR,
> and perhaps even EOI it, causing incorrect behaviour.
>
> The race is really insignificant since it can only occur on the first
> interrupt (usually following interrupts will not change TMR), but it's better
> closed than open.
The EOI handler clears TMR, so AFAICS it can occur not only on the first
interrupt.
Applied, thanks.
next prev parent reply other threads:[~2009-12-29 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 10:42 [PATCH] KVM: Fix race between APIC TMR and IRR Avi Kivity
2009-12-29 22:09 ` Marcelo Tosatti [this message]
2009-12-30 9:42 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091229220939.GA17127@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox