From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost-net: defer f->private_data until setup succeeds
Date: Mon, 4 Jan 2010 13:03:12 +1030 [thread overview]
Message-ID: <201001041303.12558.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091224060650.GA26128@redhat.com>
On Thu, 24 Dec 2009 04:36:50 pm Michael S. Tsirkin wrote:
> On Tue, Dec 22, 2009 at 11:02:28AM -0800, Chris Wright wrote:
> > Trivial change, just for readability. The filp is not installed on
> > failure, so the current code is not incorrect (also vhost_dev_init
> > currently has no failure case). This just treats setting f->private_data
> > as something with global scope (sure, true only after fd_install).
> >
> > Signed-off-by: Chris Wright <chrisw@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Thanks, applied.
Rusty.
prev parent reply other threads:[~2010-01-04 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 19:02 [PATCH] vhost-net: defer f->private_data until setup succeeds Chris Wright
2009-12-24 6:06 ` Michael S. Tsirkin
2010-01-04 2:33 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001041303.12558.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).