From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: build error
Date: Tue, 5 Jan 2010 15:08:05 -0200
Message-ID: <20100105170805.GA23996@amt.cnet>
References: <4B3B7459.7070204@czero.it> <3E44A961-57B3-450F-A173-C7CF4867A347@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-ppc <kvm-ppc@vger.kernel.org>,
	KVM General <kvm@vger.kernel.org>,
	Giuseppe Falsetti <giuseppe@czero.it>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43710 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755083Ab0AESft (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 5 Jan 2010 13:35:49 -0500
Content-Disposition: inline
In-Reply-To: <3E44A961-57B3-450F-A173-C7CF4867A347@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Jan 03, 2010 at 03:09:52AM +0100, Alexander Graf wrote:
> Hi Marcelo,
> 
> On 30.12.2009, at 16:40, Giuseppe Falsetti wrote:
> 
> > Hi,
> > I get this error when compile the git tree virt/kvm/kvm.git next
> > 
> > My machine is a Xserve G5 DUAL processor, Lenny with gcc-4.3.2
> > 
> > HOSTCC  scripts/bin2c
> > HOSTLD  scripts/mod/modpost
> > CALL    scripts/checksyscalls.sh
> > <stdin>:1523:2: warning: #warning syscall recvmmsg not implemented
> > CC      init/main.o
> > HOSTCC  usr/gen_init_cpio
> > 
> > [...]
> > 
> > LD      arch/powerpc/platforms/built-in.o
> > CC      arch/powerpc/kernel/pci_dn.o
> > LD      arch/powerpc/math-emu/built-in.o
> > CC      arch/powerpc/kernel/isa-bridge.o
> > CC      arch/powerpc/kvm/book3s_64_exports.o
> > CC      arch/powerpc/kernel/pci-common.o
> > CC      arch/powerpc/kvm/../../../virt/kvm/kvm_main.o
> > CC      arch/powerpc/kernel/pci_of_scan.o
> > CC      arch/powerpc/kvm/../../../virt/kvm/coalesced_mmio.o
> > CC      arch/powerpc/kvm/powerpc.o
> > CC      arch/powerpc/kernel/msi.o
> > CC      arch/powerpc/kernel/machine_kexec.o
> > CC      arch/powerpc/kvm/emulate.o
> > CC      arch/powerpc/kernel/crash.o
> > CC      arch/powerpc/kvm/book3s.o
> > cc1: warnings being treated as errors
> > arch/powerpc/kvm/book3s.c: In function 'kvm_vm_ioctl_get_dirty_log':
> > arch/powerpc/kvm/book3s.c:860: error: passing argument 1 of 'down_write' from incompatible pointer type
> > arch/powerpc/kvm/book3s.c:868: error: assignment from incompatible pointer type
> > arch/powerpc/kvm/book3s.c:882: error: passing argument 1 of 'up_write' from incompatible pointer type
> 
> 
> Apparently your recent memslot changes broke PowerPC. I've seen you adjusted x86, ia64 and s390. Is there any reason you've missed out on PPC?
> 
> Alex

Alex,

Ugh, parts of the PPC code have been converted but apparently not all 
of it.

Sorry about that.