Re: 0.12.x: message "Option 'ipv4': Use 'on' or 'off'"

[Marcelo Tosatti <mtosatti@redhat.com>]

On Mon, Jan 04, 2010 at 09:18:01AM +0100, Thomas Beinicke wrote:
> I get the same message since the update, is it -chardev option related?
> 
> 
> On Saturday 02 January 2010 11:53:42 Thomas Mueller wrote:
> > hi
> > 
> > since 0.12.x i get the following messages starting a vm:
> > 
> > Option 'ipv4': Use 'on' or 'off'
> > Failed to parse "yes" for "dummy.ipv4"
> > 
> > 
> > command is:
> > 
> > 
> > kvm -usbdevice tablet -drive file=~/virt/xp/drive1.qcow2,cache=writeback -
> > drive file=~/virt/xp/drive2.qcow2,cache=writeback -net nic -net
> > user,hostfwd=tcp:127.0.0.1:3389-:3389 -k de-ch -m 1024 -smp 2 -vnc
> > 127.0.0.1:20 -monitor unix:/var/run/kvm-winxp.socket,server,nowait -
> > daemonize -localtime
> > 
> > what is option ipv4?

This patch should fix it:

Fix inet_parse typo

qemu_opt_set wants on/off, not yes/no.

diff --git a/qemu-sockets.c b/qemu-sockets.c
index 8850516..a88b2a7 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
                     __FUNCTION__, str);
             return -1;
         }
-        qemu_opt_set(opts, "ipv6", "yes");
+        qemu_opt_set(opts, "ipv6", "on");
     } else if (qemu_isdigit(str[0])) {
         /* IPv4 addr */
         if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
@@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
                     __FUNCTION__, str);
             return -1;
         }
-        qemu_opt_set(opts, "ipv4", "yes");
+        qemu_opt_set(opts, "ipv4", "on");
     } else {
         /* hostname */
         if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
@@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
     if (h)
         qemu_opt_set(opts, "to", h+4);
     if (strstr(optstr, ",ipv4"))
-        qemu_opt_set(opts, "ipv4", "yes");
+        qemu_opt_set(opts, "ipv4", "on");
     if (strstr(optstr, ",ipv6"))
-        qemu_opt_set(opts, "ipv6", "yes");
+        qemu_opt_set(opts, "ipv6", "on");
     return 0;
 }