From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 4/4] KVM: VMX: Enable EPT 1GB page support
Date: Wed, 6 Jan 2010 08:02:15 -0200
Message-ID: <20100106100215.GB4553@amt.cnet>
References: <1262689349-12350-1-git-send-email-sheng@linux.intel.com> <1262689349-12350-5-git-send-email-sheng@linux.intel.com> <20100106091915.GA4553@amt.cnet> <201001061725.27571.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:25819 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754722Ab0AFKDT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 6 Jan 2010 05:03:19 -0500
Content-Disposition: inline
In-Reply-To: <201001061725.27571.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jan 06, 2010 at 05:25:27PM +0800, Sheng Yang wrote:
> > > -	for (level = PT_DIRECTORY_LEVEL; level <= host_level; ++level)
> > > +	max_level = kvm_x86_ops->get_lpage_level() < host_level ?
> > > +		kvm_x86_ops->get_lpage_level() : host_level;
> > > +
> > 
> > BUG_ON(kvm_x86_ops->get_lpage_level() < host_level) instead? See
> > the if (host_level == PT_PAGE_TABLE_LEVEL) above.
>  
> Sorry, I don't understand...
> 
> Here, EPT can support either 2MB or 1GB page at most, So we represent the 
> value through get_lpage_level(). Now 1GB page backed host memory can still 
> using by 2MB page backed EPT if 1GB page EPT is not supported in the 
> processor.

Oh, OK, i misundertood.

Applied, thanks.