From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: The HPET issue on Linux Date: Thu, 7 Jan 2010 08:45:28 +0200 Message-ID: <20100107064528.GR4905@redhat.com> References: <201001061748.52689.sheng@linux.intel.com> <20100106100957.GF4905@redhat.com> <4B44648F.2010702@redhat.com> <4B44D82A.9030805@us.ibm.com> <4B44E27F.6090406@us.ibm.com> <4B44E330.4080805@codemonkey.ws> <20100106194411.GA24476@redhat.com> <4B44E9DA.2050000@codemonkey.ws> <20100106203733.GB24476@redhat.com> <4B4511D6.1030401@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Beth Kon , dlaor@redhat.com, Sheng Yang , kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006Ab0AGGpd (ORCPT ); Thu, 7 Jan 2010 01:45:33 -0500 Content-Disposition: inline In-Reply-To: <4B4511D6.1030401@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jan 06, 2010 at 04:42:30PM -0600, Anthony Liguori wrote: > On 01/06/2010 02:37 PM, Gleb Natapov wrote: > >We have exactly that hook in apic already and that's how RTC determines > >that interrupt was coalesced. > > AFAICT, apic_irq_delivered is only reset explicitly by the RTC when > the line is lowered. It's not currently lowered based on EOI. > Correct. We can expose ACK notifiers to userspace (and if we want to move assigned devices into userspace we have to), but I'd rather avoid it. > How can this mechanism be used with the HPET when operating in edge > triggered mode? > If interrupt is coalesced increment counter and double HPET timer frequency. When counter is zeroed return HPET timer to normal frequency. -- Gleb.