From: Gleb Natapov <gleb@redhat.com>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: dbareiro@gmx.net, kvm@vger.kernel.org
Subject: Re: CPU hotplug add seems broken
Date: Mon, 11 Jan 2010 11:32:11 +0200 [thread overview]
Message-ID: <20100111093211.GD7549@redhat.com> (raw)
In-Reply-To: <5e93dcec1001110124l38d35ef7y4e92aa8b74aa810a@mail.gmail.com>
On Mon, Jan 11, 2010 at 06:24:32PM +0900, Ryota Ozaki wrote:
> 2010/1/10 Gleb Natapov <gleb@redhat.com>:
> > On Sun, Jan 10, 2010 at 05:33:02PM +0900, Ryota Ozaki wrote:
> [...]
> >> I see. Anyway I think we need some workaround to avoid segfault.
> >>
> > Disabling cpu_set command for qemu-kvm-0.12 is good enough workaround.
>
> Agree. I'll send a patch.
>
Thanks.
> >
> >> > but ACPI code that handles CPU host-plug was not ported to
> >> > SeaBIOS when it replaces BOCH BIOS.
> >>
> >> Yeah, I confirmed it during memory hotplug work...
> >>
> >> So I'd like to know when cpu hotplug comes back? I didn't see
> >> it in qemu-0.13 feature requests.
> >>
> > May I ask what do you need it for?
>
> Oh sorry, actually I have not so strong desire on cpu hotplug but
> I have on memory hotplug and just want to learn stuffs to implement
> it from cpu's one. Honestly said I'm not sure someone want it.
Hmm, everybody want it, but nobody can't say why. Looks like it just
sounds cool :)
>
> > The problem is that there is no standard
> > way to hotplug CPUs in a PC. Linux implements the way UNISYS happen to do
> > it, but no other system do it like that. Windows implements it
> > differently and in the way that conflicts with Linux, so you can't
> > have working Linux implementation and pass Microsoft SVVP test at the
> > same time for instance.
>
> Could I ask you what's the difference between the two implementations?
I have no idea how it works in Windows. It seems that some kind of
driver is required for hot-plugging cpu there.
> Don't we have a possibility to have different implementations in qemu-kvm
> (and SeaBIOS)?
What do you mean by different implementation? Different one for Windows
and Linux and have a switch to choose one? Possible, but not desirable.
Different from what we had in BOCHS BIOS? Also possible, but will
require changes to Linux kernel and older Kernel will not work.
> And also I want to ask that the problem can be applied
> to memory hotplug case?
>
AFAIK memory hotplug is part of ACPI spec and if implemented correctly
should not cause any problems.
--
Gleb.
next prev parent reply other threads:[~2010-01-11 9:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 10:35 CPU hotplug add seems broken Ryota Ozaki
2010-01-09 19:30 ` Daniel Bareiro
2010-01-10 6:39 ` Gleb Natapov
2010-01-10 8:33 ` Ryota Ozaki
2010-01-10 8:43 ` Gleb Natapov
2010-01-11 9:24 ` Ryota Ozaki
2010-01-11 9:32 ` Gleb Natapov [this message]
2010-01-11 10:21 ` Ryota Ozaki
2010-01-11 10:23 ` Avi Kivity
2010-01-11 10:24 ` Gleb Natapov
2010-01-11 10:25 ` Avi Kivity
2010-01-11 10:42 ` Gleb Natapov
2010-01-11 10:50 ` Avi Kivity
2010-01-11 10:53 ` Gleb Natapov
2010-01-11 10:58 ` Avi Kivity
2010-01-11 11:03 ` Gleb Natapov
2010-01-11 11:06 ` Avi Kivity
2010-01-11 12:18 ` Gleb Natapov
2010-01-11 13:57 ` Anthony Liguori
2010-01-11 14:32 ` Avi Kivity
2010-01-11 10:30 ` Ryota Ozaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111093211.GD7549@redhat.com \
--to=gleb@redhat.com \
--cc=dbareiro@gmx.net \
--cc=kvm@vger.kernel.org \
--cc=ozaki.ryota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).