From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: CPU hotplug add seems broken Date: Mon, 11 Jan 2010 12:53:31 +0200 Message-ID: <20100111105331.GI7549@redhat.com> References: <20100109193011.GA25426@defiant.freesoftware> <20100110063911.GG4905@redhat.com> <5e93dcec1001100033tdb930eqcaf48a36ee36b335@mail.gmail.com> <20100110084353.GI4905@redhat.com> <5e93dcec1001110124l38d35ef7y4e92aa8b74aa810a@mail.gmail.com> <4B4AFC09.3090909@redhat.com> <20100111102434.GG7549@redhat.com> <4B4AFCB0.1080706@redhat.com> <20100111104213.GH7549@redhat.com> <4B4B025D.1020309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ryota Ozaki , dbareiro@gmx.net, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6028 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495Ab0AKKxf (ORCPT ); Mon, 11 Jan 2010 05:53:35 -0500 Content-Disposition: inline In-Reply-To: <4B4B025D.1020309@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 11, 2010 at 12:50:05PM +0200, Avi Kivity wrote: > On 01/11/2010 12:42 PM, Gleb Natapov wrote: > >>> > >>>That cool, but SVVP complains. > >>What's the complaint? Maybe we can fix it instead of rewriting things. > >> > >https://bugzilla.redhat.com/show_bug.cgi?id=49584://bugzilla.redhat.com/show_bug.cgi?id=495844 > >Hope it accessible to everyone but if not SVVP complains: > >Run "Signed Driver check" of SVVP testing, the (Qemu virtual CPU verison > >0.9.1) has error. > > > >The only why to fix it that I can see is to not present disabled MADT > >entries for Windows and that will require us to provide some kind > >of flag to QEMU. The cleanest way is to create disabled MADT entries > >only if max-cpus != startup cpus and run Windows only with max-cpus == > >startup cpus. The problem is 1) you have to know what is your guest > >at startup time 2) will require creation of SSDT for Processors() > >on the fly (or precompile them for every value of max-cpus and load > >dynamically). Actually there is a third solution that I just thought > >about but I need to test it first :). > > Perhaps loading a processor driver will fix this issue (which driver > can also perform the hotplug). > Perhaps, perhaps not, who are looking into it? I know the problem I don't know solution. > >Anyway all those solution do not > >guaranty that we will be able to do cpu hotplug on Windows since we > >don't yet know what Windows expects. > > I'm sure we'll be able to eventually. > Eventually yes, but can you say now that it will not require DSDT changes or command line parameter? -- Gleb.