Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

[Gleb Natapov <gleb@redhat.com>]

On Tue, Jan 19, 2010 at 09:54:44AM +0200, Avi Kivity wrote:
> On 01/19/2010 05:06 AM, Sheng Yang wrote:
> >
> >>There are two problems with the kernel failure report.  First, it
> >>doesn't report enough data - registers, surrounding instructions, etc.
> >>that are needed to explain what is going on.  Second, it can flood
> >>dmesg, which is a pretty bad thing to do.
> >
> >When you talking about "built-in disassembler", do you talking about
> >"memsave/objdump" or some other more convenient way for this?
> >
> >And maybe we can let QEmu do some dump of the assembler code?
> >(kvm_show_code())
> 
> In the qemu monitor, type 'x/20i $eip' to get a disassembly of code
> around the current instruction pointer.
> 
If you want to see code _around_ the current instruction pointer type
'x/20i $eip-20' :) Or that is what I usually do.

> >>I have a patch somewhere that adds instruction emulation bytes (both
> >>successful and failed) to ftrace.  That may be useful, perhaps.
> >It would surely help. :)
> 
> I'll try to resurrect it.
> 
> -- 
> error compiling committee.c: too many arguments to function
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.