From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault() Date: Tue, 19 Jan 2010 09:57:57 +0200 Message-ID: <20100119075757.GJ14345@redhat.com> References: <1263545063-10285-1-git-send-email-sheng@linux.intel.com> <201001181732.25678.sheng@linux.intel.com> <4B5446BE.9070009@redhat.com> <201001191106.09684.sheng@linux.intel.com> <4B556544.5070005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sheng Yang , Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753686Ab0ASH6A (ORCPT ); Tue, 19 Jan 2010 02:58:00 -0500 Content-Disposition: inline In-Reply-To: <4B556544.5070005@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 19, 2010 at 09:54:44AM +0200, Avi Kivity wrote: > On 01/19/2010 05:06 AM, Sheng Yang wrote: > > > >>There are two problems with the kernel failure report. First, it > >>doesn't report enough data - registers, surrounding instructions, etc. > >>that are needed to explain what is going on. Second, it can flood > >>dmesg, which is a pretty bad thing to do. > > > >When you talking about "built-in disassembler", do you talking about > >"memsave/objdump" or some other more convenient way for this? > > > >And maybe we can let QEmu do some dump of the assembler code? > >(kvm_show_code()) > > In the qemu monitor, type 'x/20i $eip' to get a disassembly of code > around the current instruction pointer. > If you want to see code _around_ the current instruction pointer type 'x/20i $eip-20' :) Or that is what I usually do. > >>I have a patch somewhere that adds instruction emulation bytes (both > >>successful and failed) to ftrace. That may be useful, perhaps. > >It would surely help. :) > > I'll try to resurrect it. > > -- > error compiling committee.c: too many arguments to function > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.