From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCHv3 0/4] Add support for some HYPER-V PV features
Date: Tue, 19 Jan 2010 12:54:55 -0200
Message-ID: <20100119145455.GD12991@amt.cnet>
References: <1263736284-18780-1-git-send-email-gleb@redhat.com>
 <4B559A84.1040509@siemens.com>
 <20100119125024.GN14345@redhat.com>
 <4B55AB48.60900@redhat.com>
 <20100119130638.GO14345@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>,
	kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:48866 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751079Ab0ASOzI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Jan 2010 09:55:08 -0500
Content-Disposition: inline
In-Reply-To: <20100119130638.GO14345@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jan 19, 2010 at 03:06:38PM +0200, Gleb Natapov wrote:
> On Tue, Jan 19, 2010 at 02:53:28PM +0200, Avi Kivity wrote:
> > On 01/19/2010 02:50 PM, Gleb Natapov wrote:
> > >
> > >This should fix it:
> > 
> > Unrelated, but important:
> > 
> > >diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > >index 47c6e23..147bda7 100644
> > >--- a/arch/x86/kvm/x86.c
> > >+++ b/arch/x86/kvm/x86.c
> > >@@ -3807,11 +3807,11 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu)
> > >  	longmode = is_long_mode(vcpu)&&  cs_l == 1;
> > >
> > >  	if (!longmode) {
> > >-		param = (kvm_register_read(vcpu, VCPU_REGS_RDX)<<  32) |
> > >+		param = ((u64)kvm_register_read(vcpu, VCPU_REGS_RDX)<<  32) |
> > >  			(kvm_register_read(vcpu, VCPU_REGS_RAX)&  0xffffff);
> > 
> > This seems to be written for a 24-bit machine...
> > 
> I have plenty of those around.
> ---
> 
> Fix compilation warnings and wrong mask value.

Applied, thanks.