From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault() Date: Tue, 19 Jan 2010 16:05:26 +0800 Message-ID: <201001191605.26389.sheng@linux.intel.com> References: <1263545063-10285-1-git-send-email-sheng@linux.intel.com> <4B556544.5070005@redhat.com> <20100119075757.GJ14345@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mga05.intel.com ([192.55.52.89]:7404 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754933Ab0ASIFt (ORCPT ); Tue, 19 Jan 2010 03:05:49 -0500 In-Reply-To: <20100119075757.GJ14345@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 19 January 2010 15:57:57 Gleb Natapov wrote: > On Tue, Jan 19, 2010 at 09:54:44AM +0200, Avi Kivity wrote: > > On 01/19/2010 05:06 AM, Sheng Yang wrote: > > >>There are two problems with the kernel failure report. First, it > > >>doesn't report enough data - registers, surrounding instructions, etc. > > >>that are needed to explain what is going on. Second, it can flood > > >>dmesg, which is a pretty bad thing to do. > > > > > >When you talking about "built-in disassembler", do you talking about > > >"memsave/objdump" or some other more convenient way for this? > > > > > >And maybe we can let QEmu do some dump of the assembler code? > > >(kvm_show_code()) > > > > In the qemu monitor, type 'x/20i $eip' to get a disassembly of code > > around the current instruction pointer. > > If you want to see code _around_ the current instruction pointer type > 'x/20i $eip-20' :) Or that is what I usually do. Oh, damn, indeed very convenient... Thanks you all for this good tip. :) -- regards Yang, Sheng