From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Davide Libenzi <davidel@xmailserver.org>,
mtosatti@redhat.com, kvm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 1/3] eventfd: allow atomic read and waitqueue remove
Date: Thu, 21 Jan 2010 19:32:59 +0200 [thread overview]
Message-ID: <20100121173259.GC16707@redhat.com> (raw)
In-Reply-To: <4B588FCE.7030803@redhat.com>
On Thu, Jan 21, 2010 at 07:33:02PM +0200, Avi Kivity wrote:
> On 01/21/2010 07:23 PM, Michael S. Tsirkin wrote:
>>
>>> I agree.
>>>
>>> But I think we can solve this in another way in .32: we can clear the
>>> eventfd from irqfd->inject work, which is in process context. The new
>>> stuff is only needed for lockless clearing, no?
>>>
>> No, AFAIK there's no way to clear the counter from kernel without
>> this patch.
>>
>
> Can't you read from the file?
IMO no, the read could block.
> --
> Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-01-21 17:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 16:26 [PATCHv2 1/3] eventfd: allow atomic read and waitqueue remove Michael S. Tsirkin
2010-01-21 16:58 ` Davide Libenzi
2010-01-21 17:13 ` Avi Kivity
2010-01-21 17:14 ` Avi Kivity
2010-01-21 17:23 ` Michael S. Tsirkin
2010-01-21 17:33 ` Avi Kivity
2010-01-21 17:32 ` Michael S. Tsirkin [this message]
2010-01-21 17:47 ` Avi Kivity
2010-01-21 17:45 ` Michael S. Tsirkin
2010-01-21 17:56 ` Avi Kivity
2010-01-21 17:57 ` Avi Kivity
2010-01-21 18:02 ` Michael S. Tsirkin
2010-01-24 11:06 ` Avi Kivity
2010-01-21 17:50 ` Davide Libenzi
2010-01-21 17:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121173259.GC16707@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=davidel@xmailserver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox