From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH] Debug vcpu add
Date: Thu, 21 Jan 2010 20:31:44 +0800
Message-ID: <201001212031.45117.sheng@linux.intel.com>
References: <EB8593BCECAB3D40A8248BE0B6400A3835909017@shzsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga06.intel.com ([134.134.136.21]:2978 "EHLO
	orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752275Ab0AUMcS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 21 Jan 2010 07:32:18 -0500
In-Reply-To: <EB8593BCECAB3D40A8248BE0B6400A3835909017@shzsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thursday 21 January 2010 19:50:17 Liu, Jinsong wrote:
> From 479e84d9ce9d7d78d845f438071a4b1a44aca0bb Mon Sep 17 00:00:00 2001
> From: Liu, Jinsong <jinsong.liu@intel.com>
> Date: Fri, 22 Jan 2010 03:30:33 +0800
> Subject: [PATCH]     Debug vcpu add

Jinsong, this name is pretty strange...

I think something like "Fix vcpu hot add feature" should be more proper...

-- 
regards
Yang, Sheng

> 
>     Add 'kvm_vcpu_inited' check so that when adding vcpu it will not
>     cause segmentation fault. This is especially necessary when vpu
>     hotadd after guestos ready.
> 
>     Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
> ---
>  qemu-kvm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-kvm.c b/qemu-kvm.c
> index 599c3d6..bdf90b4 100644
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -1618,7 +1618,7 @@ static void kvm_do_load_mpstate(void *_env)
> 
>  void kvm_load_mpstate(CPUState *env)
>  {
> -    if (kvm_enabled() && qemu_system_ready)
> +    if (kvm_enabled() && qemu_system_ready && kvm_vcpu_inited(env))
>          on_vcpu(env, kvm_do_load_mpstate, env);
>  }
>