From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Fix clts
Date: Mon, 25 Jan 2010 11:25:38 -0200 [thread overview]
Message-ID: <20100125132538.GA3640@amt.cnet> (raw)
In-Reply-To: <1264328243-21604-1-git-send-email-avi@redhat.com>
On Sun, Jan 24, 2010 at 12:17:23PM +0200, Avi Kivity wrote:
> The simplistic clts implementation has a couple of flaws:
> - kvm_read_cr0_bits() is temporarily unsynchronized when vcpu->arch.cr0 changes
> - if the fpu is active, we need to clear GUEST_CR0.TS, not just
> CR_READ_SHADOW.TS, so that we don't send the guest an unexpected #NM.
>
> Fix by replacing custom logic with a call to vmx_set_cr0(), which does the
> right thing, albeit less efficiently.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2010-01-25 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 10:17 [PATCH] KVM: VMX: Fix clts Avi Kivity
2010-01-25 13:25 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125132538.GA3640@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox