From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Pass cr0.mp through to the guest when the fpu is active
Date: Mon, 25 Jan 2010 11:32:01 -0200 [thread overview]
Message-ID: <20100125133201.GB3640@amt.cnet> (raw)
In-Reply-To: <1264343200-16913-1-git-send-email-avi@redhat.com>
On Sun, Jan 24, 2010 at 04:26:40PM +0200, Avi Kivity wrote:
> When cr0.mp is clear, the guest doesn't expect a #NM in response to
> a WAIT instruction. Because we always keep cr0.mp set, it will get
> a #NM, and potentially be confused.
>
> Fix by keeping cr0.mp set only when the fpu is inactive, and passing
> it through when inactive.
>
> Reported-by: Lorenzo Martignoni <martignlo@gmail.com>
> Analyzed-by: Gleb Natapov <gleb@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2010-01-25 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 14:26 [PATCH] KVM: VMX: Pass cr0.mp through to the guest when the fpu is active Avi Kivity
2010-01-24 14:31 ` Avi Kivity
2010-01-25 13:32 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125133201.GB3640@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox