From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: VMX: Pass cr0.mp through to the guest when the fpu is active Date: Mon, 25 Jan 2010 11:32:01 -0200 Message-ID: <20100125133201.GB3640@amt.cnet> References: <1264343200-16913-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2354 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753689Ab0AYNmP (ORCPT ); Mon, 25 Jan 2010 08:42:15 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0PDgFml008227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Jan 2010 08:42:15 -0500 Content-Disposition: inline In-Reply-To: <1264343200-16913-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Jan 24, 2010 at 04:26:40PM +0200, Avi Kivity wrote: > When cr0.mp is clear, the guest doesn't expect a #NM in response to > a WAIT instruction. Because we always keep cr0.mp set, it will get > a #NM, and potentially be confused. > > Fix by keeping cr0.mp set only when the fpu is inactive, and passing > it through when inactive. > > Reported-by: Lorenzo Martignoni > Analyzed-by: Gleb Natapov > Signed-off-by: Avi Kivity Applied, thanks.