From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] RFC: alias rework
Date: Mon, 25 Jan 2010 18:49:25 -0200
Message-ID: <20100125204925.GA23079@amt.cnet>
References: <20100125155344.327ba0d8@redhat.com>
 <20100125194553.GB20572@amt.cnet>
 <20100125215743.6442b1e4@redhat.com>
 <20100125202039.GB21800@amt.cnet>
 <20100125224032.19bc6890@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Izik Eidus <ieidus@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751393Ab0AYVfA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jan 2010 16:35:00 -0500
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0PLYxWu014108
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Mon, 25 Jan 2010 16:34:59 -0500
Content-Disposition: inline
In-Reply-To: <20100125224032.19bc6890@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jan 25, 2010 at 10:40:32PM +0200, Izik Eidus wrote:
> On Mon, 25 Jan 2010 18:20:39 -0200
> Marcelo Tosatti <mtosatti@redhat.com> wrote:
> 
> > With current code, if a memslot is deleted, access through any aliases
> > that use it will fail (BTW it looks this is not properly handled, but
> > thats a separate problem).
> 
> 
> Yea I had some still open concerns about this code (this why I sent it on RFC)
> 
> > 
> > So AFAICS there is no requirement for an alias to continue "operable" 
> > if its parent memslot is deleted.
> 
> 
> With this patch alias will stop to opearte when the parent is deleted
> just like the behivor with the current code...
> 
> base_gfn will be set to 0 and npages will be set to 0 as well
> (the true values wil be hide in real_base_gfn...), so gfn_to_memslot
> and gfn_to_page will fail....

But you adjust the alias (and keep it valid) if dirty logging is
enabled?

> > 
> > Or is this a feature you need?
> 
> 
> I dont need it (I asked Avi to do something), So he said he want to nuke the aliasing
> from kvm and keep supporting the old userspace`s

With feature i meant keeping the alias around when parent slot is
deleted.

> Do you have any other way to achive this?

No.

> Btw I do realize it might be better not to push this patch and just keep the old
> way of treating aliasing as we have now, I really don`t mind.
> 
> > 
> > Motivation is that nukeing aliases is simpler than adjusting them.
> > 
> 
> Agree.