From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg Date: Tue, 26 Jan 2010 08:46:45 +0200 Message-ID: <20100126064645.GI8483@redhat.com> References: <4B5DCAF2.3010105@redhat.com> <4B5DCB93.7050007@redhat.com> <4B5DCC53.508@redhat.com> <2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de> <4B5DD13F.5060105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Graf , QEMU Developers , KVM General , "Kevin O'Connor" , Avi Kivity , Anthony Liguori To: Jes Sorensen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9689 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751860Ab0AZGrE (ORCPT ); Tue, 26 Jan 2010 01:47:04 -0500 Content-Disposition: inline In-Reply-To: <4B5DD13F.5060105@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 25, 2010 at 06:13:35PM +0100, Jes Sorensen wrote: > On 01/25/10 17:58, Alexander Graf wrote: > >Howdy. Congratulations to the new mail address - looks neat ;-). > > :-) > > >Two comments: > > > >1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure > >You'd get one variable for len of the table, one with the contents. So for a universal reserved region specifier you'd get: > > > > > > > >Then have len=2 and put data in the table: > > > > > > > >That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the table. > > I am fine with having QEMU build the e820 tables completely if there is > a consensus to take that path. > QEMU can't build the e820 map completely. There are things it doesn't know. Like how much memory ACPI tables take and where they are located. > >2) Please inline patches. They showed up as attachments here, making them really hard to comment on. > > Sorry Thunderbug doesn't do that well, but they should be attached as > txt? > > Cheers, > Jes > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.