From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v3][uqmaster] kvm: Flush coalesced MMIO buffer periodly
Date: Tue, 26 Jan 2010 10:43:04 -0200 [thread overview]
Message-ID: <20100126124304.GB25128@amt.cnet> (raw)
In-Reply-To: <1264504876-24493-1-git-send-email-sheng@linux.intel.com>
On Tue, Jan 26, 2010 at 07:21:16PM +0800, Sheng Yang wrote:
> The default action of coalesced MMIO is, cache the writing in buffer, until:
> 1. The buffer is full.
> 2. Or the exit to QEmu due to other reasons.
>
> But this would result in a very late writing in some condition.
> 1. The each time write to MMIO content is small.
> 2. The writing interval is big.
> 3. No need for input or accessing other devices frequently.
>
> This issue was observed in a experimental embbed system. The test image
> simply print "test" every 1 seconds. The output in QEmu meets expectation,
> but the output in KVM is delayed for seconds.
>
> Per Avi's suggestion, I hooked flushing coalesced MMIO buffer in VGA update
> handler. By this way, We don't need vcpu explicit exit to QEmu to
> handle this issue.
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2010-01-26 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 9:41 [PATCH v2][uqmaster] kvm: Flush coalesced MMIO buffer periodly Sheng Yang
2010-01-26 9:59 ` Alexander Graf
2010-01-26 11:17 ` Sheng Yang
2010-01-26 11:21 ` [PATCH v3][uqmaster] " Sheng Yang
2010-01-26 12:43 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126124304.GB25128@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox