From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] QMP: Emit Basic events Date: Wed, 27 Jan 2010 19:36:28 -0200 Message-ID: <20100127213628.GA21713@amt.cnet> References: <20100126182508.3c7186b6@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Luiz Capitulino Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756184Ab0A0WWo (ORCPT ); Wed, 27 Jan 2010 17:22:44 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0RMMipd018574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jan 2010 17:22:44 -0500 Content-Disposition: inline In-Reply-To: <20100126182508.3c7186b6@doriath> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 26, 2010 at 06:25:08PM -0200, Luiz Capitulino wrote: > > While testing QMP on qemu-kvm I found that it's not emitting basic > events like RESET or POWERDOWN. > > The reason is that in QEMU upstream those events are triggered > in QEMU's main loop (ie. vl.c:main_loop()), but control doesn't > reach there in qemu-kvm as it has its own main loop in > qemu-kvm.c:kvm_main_loop(). > > This commit adds the same set of events there too. > > NOTE: The STOP event is not being added because it should be > triggered in vm_stop() and not in the main loop, this will be > fixed upstream. > > Signed-off-by: Luiz Capitulino Applied, thanks.