From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm <kvm@vger.kernel.org>
Subject: Re: qemu-kvm: enable get/set vcpu events on reset and migration
Date: Thu, 28 Jan 2010 15:55:57 +0200 [thread overview]
Message-ID: <20100128135557.GP739@redhat.com> (raw)
In-Reply-To: <20100127002622.GB8811@amt.cnet>
On Tue, Jan 26, 2010 at 10:26:22PM -0200, Marcelo Tosatti wrote:
> @@ -374,6 +375,7 @@ static int cpu_post_load(void *opaque, int version_id)
>
> kvm_load_tsc(env);
> kvm_load_mpstate(env);
> + kvm_put_vcpu_events(env);
> }
It is confusing to call functions load/save for some state and put/get for
others, but the function kvm_put_vcpu_events() is called upstream this
way :(
Otherwise looks OK.
--
Gleb.
next prev parent reply other threads:[~2010-01-28 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 0:26 qemu-kvm: enable get/set vcpu events on reset and migration Marcelo Tosatti
2010-01-27 8:36 ` Jan Kiszka
2010-01-27 22:44 ` Marcelo Tosatti
2010-01-28 8:27 ` Jan Kiszka
2010-01-28 13:55 ` Gleb Natapov [this message]
2010-01-28 14:02 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128135557.GP739@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox