From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses() Date: Fri, 29 Jan 2010 15:46:18 +0800 Message-ID: <201001291546.18258.sheng@linux.intel.com> References: <4B62901B.9020403@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Gui Jianfeng , avi@redhat.com To: Marcelo Tosatti Return-path: Received: from mga05.intel.com ([192.55.52.89]:60429 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752893Ab0A2HrX (ORCPT ); Fri, 29 Jan 2010 02:47:23 -0500 In-Reply-To: <4B62901B.9020403@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On Friday 29 January 2010 15:36:59 Gui Jianfeng wrote: > flexpriority_enabled implies cpu_has_vmx_virtualize_apic_accesses() > returning true, so we don't need this check here. > Looks fine to me. -- regards Yang, Sheng > Signed-off-by: Gui Jianfeng > --- > arch/x86/kvm/vmx.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 9f56110..0e6af4a 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -358,9 +358,7 @@ static inline int cpu_has_vmx_ple(void) > > static inline int vm_need_virtualize_apic_accesses(struct kvm *kvm) > { > - return flexpriority_enabled && > - (cpu_has_vmx_virtualize_apic_accesses()) && > - (irqchip_in_kernel(kvm)); > + return flexpriority_enabled && irqchip_in_kernel(kvm); > } > > static inline int cpu_has_vmx_vpid(void) >