* [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses()
@ 2010-01-29 7:36 Gui Jianfeng
2010-01-29 7:46 ` Sheng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Gui Jianfeng @ 2010-01-29 7:36 UTC (permalink / raw)
To: avi; +Cc: kvm
flexpriority_enabled implies cpu_has_vmx_virtualize_apic_accesses() returning
true, so we don't need this check here.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
arch/x86/kvm/vmx.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 9f56110..0e6af4a 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -358,9 +358,7 @@ static inline int cpu_has_vmx_ple(void)
static inline int vm_need_virtualize_apic_accesses(struct kvm *kvm)
{
- return flexpriority_enabled &&
- (cpu_has_vmx_virtualize_apic_accesses()) &&
- (irqchip_in_kernel(kvm));
+ return flexpriority_enabled && irqchip_in_kernel(kvm);
}
static inline int cpu_has_vmx_vpid(void)
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses()
2010-01-29 7:36 [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses() Gui Jianfeng
@ 2010-01-29 7:46 ` Sheng Yang
2010-02-01 18:04 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Sheng Yang @ 2010-01-29 7:46 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm, Gui Jianfeng, avi
On Friday 29 January 2010 15:36:59 Gui Jianfeng wrote:
> flexpriority_enabled implies cpu_has_vmx_virtualize_apic_accesses()
> returning true, so we don't need this check here.
>
Looks fine to me.
--
regards
Yang, Sheng
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
> arch/x86/kvm/vmx.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 9f56110..0e6af4a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -358,9 +358,7 @@ static inline int cpu_has_vmx_ple(void)
>
> static inline int vm_need_virtualize_apic_accesses(struct kvm *kvm)
> {
> - return flexpriority_enabled &&
> - (cpu_has_vmx_virtualize_apic_accesses()) &&
> - (irqchip_in_kernel(kvm));
> + return flexpriority_enabled && irqchip_in_kernel(kvm);
> }
>
> static inline int cpu_has_vmx_vpid(void)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses()
2010-01-29 7:46 ` Sheng Yang
@ 2010-02-01 18:04 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2010-02-01 18:04 UTC (permalink / raw)
To: Sheng Yang; +Cc: kvm, Gui Jianfeng, avi
On Fri, Jan 29, 2010 at 03:46:18PM +0800, Sheng Yang wrote:
> On Friday 29 January 2010 15:36:59 Gui Jianfeng wrote:
> > flexpriority_enabled implies cpu_has_vmx_virtualize_apic_accesses()
> > returning true, so we don't need this check here.
> >
> Looks fine to me.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-01 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-29 7:36 [PATCH] KVM: Remove redundant check in vm_need_virtualize_apic_accesses() Gui Jianfeng
2010-01-29 7:46 ` Sheng Yang
2010-02-01 18:04 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox