From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Date: Wed, 3 Feb 2010 16:36:35 -0200 Message-ID: <20100203183635.GA860@amt.cnet> References: <20100203165051.GA29235@amt.cnet> <4B69BA52.5050006@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , "kvm@vger.kernel.org" , Anthony Liguori , Alexander Graf , Glauber Costa , "qemu-devel@nongnu.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34274 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756786Ab0BCShq (ORCPT ); Wed, 3 Feb 2010 13:37:46 -0500 Content-Disposition: inline In-Reply-To: <4B69BA52.5050006@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Feb 03, 2010 at 07:02:58PM +0100, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: > >> This version addresses the feedback on v2, namely: > >> - assert( || thread>) on low-level > >> load/save registers > >> - fixed mpstate initialization > >> > >> Yet untested is -no-kvm-irqchip with smp due to some bug in unpatched > >> qemu-kvm or the kernel modules. Still investigating. > > > > Don't recall it ever working properly. Guess that IPI emulation with > > signals is problematic. > > OK, then it only works by chance on some boxes. Specifically, forcing > qemu onto a single host core "solves" the issue - suspicious. > > > > >> Pull URL is still > > >> git://git.kiszka.org/qemu-kvm.git queues/vcpu-state > >> > >> PS: The corresponding upstream queue is now available under > >> queues/kvm-upstream in the same repository. Will send it out later if > >> there are no further remarks on this series to avoid flooding the > >> mailing lists. Early testers are nevertheless welcome. > > > > Can the necessary changes for cleanups go in qemu.git first, so after > > they're merged in qemu-kvm, we can apply the unification patches. > > > > And later do the same with synchronization rework (API looks fine to > > me). > > Fine with me. Will send out my upstream queue - against uq/master or > directly against qemu.git then? Please send only the cleanups (up to 0160a98b9415603f583aec49b21dbd98b46ac969) for qemu.git for now, since Avi/others might have comments on the synchronization changes.