Re: [PATCH 04/11] VT-d: Change {un}map_range functions to implement {un}map interface

David Woodhouse
2010-01-28T20:59:42Z

On Thu, 2010-01-28 at 12:37 +0100, Joerg Roedel wrote:
> This patch changes the iommu-api functions for mapping and
> unmapping page ranges to use the new page-size based
> interface. This allows to remove the range based functions
> later.

> + size = 0x1000UL << gfp_order;

Um, that's not a page-size based interface. Page size isn't always 4KiB;
this code runs on IA64 too.

We have enough fun with CPU vs. DMA page size on IA64 already :)

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation