Re: [PATCH 04/11 v2] VT-d: Change {un}map_range functions to implement {un}map interface

Joerg Roedel
2010-02-05T11:00:11Z

Hi David,

On Mon, Feb 01, 2010 at 03:16:46PM +0100, Joerg Roedel wrote:
> On Fri, Jan 29, 2010 at 10:05:26AM +0100, Joerg Roedel wrote:
> > > Um, that's not a page-size based interface. Page size isn't always 4KiB;
> > > this code runs on IA64 too.
> > >
> > > We have enough fun with CPU vs. DMA page size on IA64 already :)
> >
> > Ah right. So this should be
> >
> > size = PAGE_SIZE << gfp_order;
> >
> > Right? The interface is meant to map the same amount of memory which
> > alloc_pages(gfp_order) would return. Same for the return value of the
> > unmap function.
>
> Ok, here is an updated patch (also updated in the iommu/largepage
> branch). Does it look ok to you David?

have you had a chance to look at the new version of the patch? If you
are fine with it and with the overall concept of this patchset I would
be cool if you could give your Acks. I would like to send this code to
Linus in the next merge window.

Thanks,

Joerg