From: Rusty Russell <rusty@rustcorp.com.au>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: "Michael S. Tsirkin <mst"@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] virtio_net: remove send queue
Date: Mon, 8 Feb 2010 12:11:13 +1030 [thread overview]
Message-ID: <201002081211.13959.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1265147331.672.20.camel@localhost.localdomain>
On Wed, 3 Feb 2010 08:18:51 am Shirley Ma wrote:
> Use detach buffers API in virtio to free unused buffers in send queue when shutting down
> virtio_net to avoid maintaining skb link list for each transmit packet.
>
> Signed-off-by: Shirley Ma <xma@us.ibm.com>
Hi Shirley,
Nice cleanup. Please cc: netdev@vger.kernel.org for net patches...
Your comment could be slightly enhanced to indicate that the API is new, eg;
Now we have a virtio detach API (in commit XXXXXXXXXX), we don't need to
track xmit skbs in the driver.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks!
Rusty.
next prev parent reply other threads:[~2010-02-08 1:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201001292346.43675.rusty@rustcorp.com.au>
[not found] ` <201001292349.05360.rusty@rustcorp.com.au>
[not found] ` <201001292350.04544.rusty@rustcorp.com.au>
2010-02-02 21:48 ` [PATCH 1/1 net-next] virtio_net: remove send queue Shirley Ma
2010-02-02 21:52 ` [PATCH 0/1 " Shirley Ma
2010-02-03 10:03 ` [PATCH 1/1 " Michael S. Tsirkin
2010-02-08 1:41 ` Rusty Russell [this message]
2010-02-09 0:14 Shirley Ma
2010-02-10 16:54 ` Shirley Ma
2010-02-12 20:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002081211.13959.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc="Michael S. Tsirkin <mst"@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mashirle@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox