From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/1 net-next] virtio_net: remove send queue
Date: Mon, 8 Feb 2010 12:11:13 +1030
Message-ID: <201002081211.13959.rusty@rustcorp.com.au>
References: <201001292346.43675.rusty@rustcorp.com.au> <201001292350.04544.rusty@rustcorp.com.au> <1265147331.672.20.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: "Michael S. Tsirkin <mst"@redhat.com, kvm@vger.kernel.org
To: Shirley Ma <mashirle@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:33425 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753878Ab0BHBlS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 7 Feb 2010 20:41:18 -0500
In-Reply-To: <1265147331.672.20.camel@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 3 Feb 2010 08:18:51 am Shirley Ma wrote:
> Use detach buffers API in virtio to free unused buffers in send queue when shutting down 
> virtio_net to avoid maintaining skb link list for each transmit packet.
> 
> Signed-off-by: Shirley Ma <xma@us.ibm.com>

Hi Shirley,

  Nice cleanup.  Please cc: netdev@vger.kernel.org for net patches...

Your comment could be slightly enhanced to indicate that the API is new, eg;

	Now we have a virtio detach API (in commit XXXXXXXXXX), we don't need to
	track xmit skbs in the	driver.

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks!
Rusty.