From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 4/4] KVM: Rework of guest debug state writing
Date: Mon, 8 Feb 2010 13:52:26 -0200
Message-ID: <20100208155226.GC2887@amt.cnet>
References: <cover.1265232578.git.jan.kiszka@siemens.com>
 <372238c800e0d57815f472502fdf78e53463bbb6.1265232579.git.jan.kiszka@siemens.com>
 <20100203234929.GA11012@amt.cnet>
 <4B6A15EE.4050501@web.de>
 <20100204130038.GA15671@amt.cnet>
 <4B6AE1E6.9040805@siemens.com>
 <4B6AEAB8.3030509@siemens.com>
 <20100204180555.GA3861@amt.cnet>
 <4B6B179A.3080704@siemens.com>
 <4B6B194A.90009@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:61853 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752937Ab0BHPxI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 8 Feb 2010 10:53:08 -0500
Content-Disposition: inline
In-Reply-To: <4B6B194A.90009@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Feb 04, 2010 at 08:00:26PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Marcelo Tosatti wrote:
> >>
> >> Unrelated to this problem, won't put_vcpu_events, which is executed 
> >> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
> > 
> > Good point, SET_GUEST_DEBUG should be last in the writeback for that reason.
> 
> Actually, we no longer need the exception injection via SET_GUEST_DEBUG
> now that we have full access via vcpu_events. 

> So this needs a cleanup, and I'm afraid quite a few cases are broken
> ATM with vcpu_events writeback overwriting the reinjected exceptions.

Don't see what you mean here. Can you be more explicit? What breakage?