From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v3 0/4] KVM: rework of "Fix x86 emulator's fault propagations" Date: Fri, 12 Feb 2010 09:09:38 +0200 Message-ID: <20100212070938.GC15678@redhat.com> References: <20100212155044.96fb69f6.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385Ab0BLHJl (ORCPT ); Fri, 12 Feb 2010 02:09:41 -0500 Content-Disposition: inline In-Reply-To: <20100212155044.96fb69f6.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Feb 12, 2010 at 03:50:44PM +0900, Takuya Yoshikawa wrote: > This is the rework of "Fix x86 emulator's fault propagations". > -- http://www.spinics.net/lists/kvm/msg28874.html > > I read the review comments from Avi, Marcelo and Gleb and removed > some parts which should be done with more care: descriptor related > part and emulator_sys* part. > > Now the contents is like this: > - patch 1: X86EMUL macro replacements: from do_fetch_insn_byte() > to x86_decode_insn() > - patch 2: X86EMUL macro replacements: x86_emulate_insn() and its > helpers > - patch 3: Fix x86_emulate_insn() not to use the variable rc for > non-X86EMUL values > - patch 4: Tiny fix: remove redundant prototype of load_pdptrs() > > > Gleb, could you give me your Ack? > Looks good to me. Thanks. -- Gleb.