From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio-spec: document MSI-X Date: Fri, 12 Feb 2010 12:47:54 +0200 Message-ID: <20100212104754.GD21947@redhat.com> References: <20100211172236.GA20357@redhat.com> <201002122017.55536.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: virtualization@lists.linux-foundation.org, markmc@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Rusty Russell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60427 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986Ab0BLKvu (ORCPT ); Fri, 12 Feb 2010 05:51:50 -0500 Content-Disposition: inline In-Reply-To: <201002122017.55536.rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Feb 12, 2010 at 08:17:55PM +1030, Rusty Russell wrote: > On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote: > > This documents MSI-X support in virtio. > > > > Signed-off-by: Michael S. Tsirkin > > Wow, great! > > I reworked one paragraph for better grammar. Mainly adding "the": > > (pseudo-patch): > Devices report such failures by returning +the+ NO_VECTOR value > when the relevant Vector field is read. After mapping an event to vector, > +the+ driver must verify success by reading the Vector field value: on > success, +the+ previously written value is returned-;-+, and+ on failure, > NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+ > driver can retry mapping with +fewer+-less- vectors, or disable MSI-X. Looks good, thanks for the corrections! > I really liked the conversational style: standards can be intimidating and > unfriendly documents if they concentrate too much on partitioning all > information into precise sections. > > That makes it 0.8.6. I will re-read the entire document for consistency > before releasing 0.9. > > Thanks! > Rusty.