From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] virtio-spec: document MSI-X
Date: Fri, 12 Feb 2010 20:17:55 +1030
Message-ID: <201002122017.55536.rusty@rustcorp.com.au>
References: <20100211172236.GA20357@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: virtualization@lists.linux-foundation.org, markmc@redhat.com,
	Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:59697 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752122Ab0BLJsB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 12 Feb 2010 04:48:01 -0500
In-Reply-To: <20100211172236.GA20357@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> This documents MSI-X support in virtio.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Wow, great!

I reworked one paragraph for better grammar.  Mainly adding "the":

(pseudo-patch):
    Devices report such failures by returning +the+ NO_VECTOR value
    when the relevant Vector field is read. After mapping an event to vector,
    +the+ driver must verify success by reading the Vector field value: on
    success, +the+ previously written value is returned-;-+, and+ on failure,
    NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
    driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.

I really liked the conversational style: standards can be intimidating and
unfriendly documents if they concentrate too much on partitioning all
information into precise sections.

That makes it 0.8.6.  I will re-read the entire document for consistency
before releasing 0.9.

Thanks!
Rusty.