From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP
Date: Sun, 14 Feb 2010 14:43:43 +0200
Message-ID: <20100214124343.GK2511@redhat.com>
References: <4B767160.4070609@web.de>
 <20100214075303.GF2511@redhat.com>
 <4B77CFD7.9080504@web.de>
 <20100214103445.GH2511@redhat.com>
 <4B77EC14.4000302@redhat.com>
 <4B77EF0D.4050303@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:53151 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754154Ab0BNMnr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 14 Feb 2010 07:43:47 -0500
Content-Disposition: inline
In-Reply-To: <4B77EF0D.4050303@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Feb 14, 2010 at 01:39:41PM +0100, Jan Kiszka wrote:
> Avi Kivity wrote:
> > On 02/14/2010 12:34 PM, Gleb Natapov wrote:
> >>>>
> >>>> event_exit_inst_len is only used for event reinjection. Since event
> >>>> intercepted here will not be reinjected why updating
> >>>> event_exit_inst_len
> >>>> is needed here?
> >>>>        
> >>> In guest debugging mode a #BP exception is always reported to user space
> >>> to find out what caused it. If it was the guest itself, the exception is
> >>> reinjected, on older kernels via KVM_SET_GUEST_DEBUG and since 2.6.33
> >>> via KVM_SET_VCPU_EVENTS (the latter requires some qemu patch that I will
> >>> post later).
> >>>
> >>> As we currently do not update event_exit_inst_len on #BP exits,
> >>> reinjecting fails unless event_exit_inst_len happens to be 1 from some
> >>> other exit.
> >>>
> >>>      
> >> Hmm, how does it work on SVM then where we do not have
> >> event_exit_inst_len so execution will resume on the same rip that caused
> >> #BP after event reinjection?
> >>
> >>    
> > 
> > Note, newer AMDs do have such a field (nRIP, 0xC8).  We need to support
> > older machines, though.
> > 
> 
> Nice.
> 
> [ /me goes updating his manual - September 07... ]
> 
I can't find nothing newer then that. What is the link?

--
			Gleb.