[PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

[PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi,

Comparing the features tested for in get_para_features() with the
kvm_feature_names in target-i386/helper.c, I noticed that we didn't
list the cr3_cache feature in the real name table.

I presume this is unintentional so here's a patch to correct it.

Cheers,
Jes


[-- Attachment #2: 0000-kvm_cr3_catch-name.patch --]
[-- Type: text/plain, Size: 932 bytes --]

commit 39cb576d15a6ffbbcade3c4f282c2f3e76e3098a
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date:   Wed Feb 17 18:03:37 2010 +0100

    Add kvm_cr3_cache to the list of KVM features.
    
    This is to match the features automatically added by
    target-i386/kvm.c:get_para_features()
    
    Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>

diff --git a/target-i386/helper.c b/target-i386/helper.c
index f9d63f6..2cd3dca 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -61,7 +61,8 @@ static const char *ext3_feature_name[] = {
 };
 
 static const char *kvm_feature_name[] = {
-    "kvmclock", "kvm_nopiodelay", "kvm_mmu", NULL, NULL, NULL, NULL, NULL,
+    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvm_cr3_cache",
+    NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

[Marcelo Tosatti]

On Wed, Feb 17, 2010 at 06:44:12PM +0100, Jes Sorensen wrote:
> Hi,
> 
> Comparing the features tested for in get_para_features() with the
> kvm_feature_names in target-i386/helper.c, I noticed that we didn't
> list the cr3_cache feature in the real name table.
> 
> I presume this is unintentional so here's a patch to correct it.
> 
> Cheers,
> Jes
> 

The KVM_CAP_CR3_CACHE reference can be removed since the feature 
was never implemented/included.

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

[Jes Sorensen]

On 02/17/10 22:08, Marcelo Tosatti wrote:
> The KVM_CAP_CR3_CACHE reference can be removed since the feature
> was never implemented/included.

Ok that works too, would you rather a patch to remove all references
to it, or leave it in in case someone decides to pick it up later?

Cheers,
Jes

Re: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache

[Marcelo Tosatti]

On Wed, Feb 17, 2010 at 10:26:56PM +0100, Jes Sorensen wrote:
> On 02/17/10 22:08, Marcelo Tosatti wrote:
> >The KVM_CAP_CR3_CACHE reference can be removed since the feature
> >was never implemented/included.
> 
> Ok that works too, would you rather a patch to remove all references
> to it, or leave it in in case someone decides to pick it up later?

I'd say remove all references, its obsolete due to EPT/NPT.

> 
> Cheers,
> Jes
>