Re: [patch uq/master 2/4] qemu: kvm specific wait_io_event

[Marcelo Tosatti <mtosatti@redhat.com>]

On Thu, Feb 18, 2010 at 10:29:35AM +0200, Avi Kivity wrote:
> >+static void qemu_kvm_wait_io_event(CPUState *env)
> >+{
> >+    while (!cpu_has_work(env))
> >+        qemu_cond_timedwait(env->halt_cond,&qemu_global_mutex, 1000);
> >+
> >+    qemu_wait_io_event_common(env);
> >  }
> 
> Shouldn't kvm specific code be in kvm-all.c?

The context is in vl.c, so don't see much gain.

> >
> >  static int qemu_cpu_exec(CPUState *env);
> >@@ -3448,7 +3462,7 @@ static void *kvm_cpu_thread_fn(void *arg
> >      while (1) {
> >          if (cpu_can_run(env))
> >              qemu_cpu_exec(env);
> >-        qemu_wait_io_event(env);
> >+        qemu_kvm_wait_io_event(env);
> >      }
> >
> >      return NULL;
> 
> Well, kvm_cpu_thread_fn() apparently isn't.