Re: [PATCH 6/6] KVM: x86: Emulator support for TF

Gleb Natapov
2010-02-23T12:05:30Z

On Tue, Feb 23, 2010 at 01:41:44PM +0200, Avi Kivity wrote:
> On 02/23/2010 01:30 PM, Jan Kiszka wrote:
> >>
> >>How to detect that emulation is complete? emulate_instruction() should
> >>return EMULATE_DONE in this case.
> >...*and* RIP moved forward.
>
> A branch or rep instruction can successfully execute and not change rip.
>
Jmp instruction can successfully execute and not change rip :) Also
I think exception generation should be considered as part of instruction
execution and sometimes even intended effect (ud instructions for
instance).

> Btw, do we expect a #DB on every iteration of rep? In this case we
> need to modify the code, currently we'll batch rep;ins and rep;outs
> up to a page's worth.
>
> --
> error compiling committee.c: too many arguments to function

--
Gleb.