From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF
Date: Tue, 23 Feb 2010 14:05:26 +0200
Message-ID: <20100223120526.GL29041@redhat.com>
References: <cover.1266861080.git.jan.kiszka@siemens.com>
 <d2ff843bee1c26d131532889ba4423fc0ff3c983.1266861081.git.jan.kiszka@siemens.com>
 <20100223095553.GC29041@redhat.com>
 <4B83A9B1.2060103@siemens.com>
 <20100223102620.GF29041@redhat.com>
 <4B83AFE1.3070905@siemens.com>
 <20100223110054.GI29041@redhat.com>
 <4B83BC53.6090102@siemens.com>
 <4B83BEF8.5050503@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:15054 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752471Ab0BWMFa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 23 Feb 2010 07:05:30 -0500
Content-Disposition: inline
In-Reply-To: <4B83BEF8.5050503@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Feb 23, 2010 at 01:41:44PM +0200, Avi Kivity wrote:
> On 02/23/2010 01:30 PM, Jan Kiszka wrote:
> >>
> >>How to detect that emulation is complete? emulate_instruction() should
> >>return EMULATE_DONE in this case.
> >...*and* RIP moved forward.
> 
> A branch or rep instruction can successfully execute and not change rip.
> 
Jmp instruction can successfully execute and not change rip :) Also
I think exception generation should be considered as part of instruction
execution and sometimes even intended effect (ud instructions for
instance).

> Btw, do we expect a #DB on every iteration of rep?  In this case we
> need to modify the code, currently we'll batch rep;ins and rep;outs
> up to a page's worth.
> 
> -- 
> error compiling committee.c: too many arguments to function

--
			Gleb.