From: Joerg Roedel <joerg.roedel@amd.com>
To: Alexander Graf <agraf@suse.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging
Date: Wed, 24 Feb 2010 20:37:01 +0100 [thread overview]
Message-ID: <20100224193700.GE3168@amd.com> (raw)
In-Reply-To: <402BABD5-304A-47EA-B35C-D0E3948BB27E@suse.de>
On Wed, Feb 24, 2010 at 08:27:50PM +0100, Alexander Graf wrote:
> > + static const u32 msrpm_offsets[] = {
> > + 0x0000002c, /* SYSENTER_CS */
> > +
> > + 0x00000038, /* LASTBRANCHFROMIP
> > + LASTBRANCHTOIP
> > + LASTINTFROMIP
> > + LASTINTTOIP */
> > +
> > + 0x00000820, /* STAR
> > + LSTAR
> > + CSTAR
> > + SYSCALL_MASK */
> > +
> > + 0x00000840, /* FS_BASE
> > + GS_BASE
> > + KERNEL_GS_BASE */
> > +
> > + 0xffffffff, /* End of List */
>
> Isn't there such a list around somewhere already? We really should
> only keep this list once throughout the whole code. If necessary, just
> create the list on the fly when bits get set in the msrpm.
No, the list is hardcoded in 3 functions (as parameter of
set_msr_interception). I think about a variant to do this with a single
list. Probably I create a list of MSRs and check in
set_msr_interceptionm for it.
Joerg
next prev parent reply other threads:[~2010-02-24 19:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 17:59 [PATCH 0/11] Another set of nested svm fixes and optimizations Joerg Roedel
2010-02-24 17:59 ` [PATCH 01/11] KVM: SVM: Coding style cleanup Joerg Roedel
2010-02-24 18:02 ` Joerg Roedel
2010-02-24 17:59 ` [PATCH 02/11] KVM: SVM: Reset MMU on nested_svm_vmrun for NPT too Joerg Roedel
2010-02-24 17:59 ` [PATCH 03/11] KVM: SVM: Check for nested intercepts on NMI injection Joerg Roedel
2010-02-24 17:59 ` [PATCH 04/11] KVM: SVM: Restore tracing of nested vmcb address Joerg Roedel
2010-02-24 17:59 ` [PATCH 05/11] KVM: SVM: Add kvm_nested_intercepts tracepoint Joerg Roedel
2010-02-24 17:59 ` [PATCH 06/11] KVM: SVM: Implement emulation of vm_cr msr Joerg Roedel
2010-02-25 10:28 ` Avi Kivity
2010-02-24 17:59 ` [PATCH 07/11] KVM: SVM: Ignore write of hwcr.ignne Joerg Roedel
2010-02-24 17:59 ` [PATCH 08/11] KVM: x86: Don't set arch.cr0 in kvm_set_cr0 Joerg Roedel
2010-02-24 17:59 ` [PATCH 09/11] KVM: SVM: Handle nested selective_cr0 intercept correctly Joerg Roedel
2010-02-24 17:59 ` [PATCH 10/11] KVM: SVM: Clear exit_info for injected INTR exits Joerg Roedel
2010-02-24 17:59 ` [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging Joerg Roedel
2010-02-24 19:27 ` Alexander Graf
2010-02-24 19:37 ` Joerg Roedel [this message]
2010-02-24 19:58 ` Avi Kivity
2010-02-24 20:00 ` Alexander Graf
2010-02-24 20:09 ` Avi Kivity
2010-02-25 10:32 ` [PATCH 0/11] Another set of nested svm fixes and optimizations Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224193700.GE3168@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox