Re: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging

Alexander Graf
2010-02-24T20:00:03Z

On 24.02.2010, at 20:58, Avi Kivity wrote:

> On 02/24/2010 09:37 PM, Joerg Roedel wrote:
>>
>>> Isn't there such a list around somewhere already? We really should
>>> only keep this list once throughout the whole code. If necessary, just
>>> create the list on the fly when bits get set in the msrpm.
>>>
>> No, the list is hardcoded in 3 functions (as parameter of
>> set_msr_interception). I think about a variant to do this with a single
>> list. Probably I create a list of MSRs and check in
>> set_msr_interceptionm for it.
>>
>>
>
> Or, have set_msr_interception() create the list of offsets.

Or even better yet put the list into BSS because it should be static anyways. From that the real MSRPM and the merging function can be fed.

Alex