Re: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging

Joerg Roedel
2010-02-24T19:37:11Z

On Wed, Feb 24, 2010 at 08:27:50PM +0100, Alexander Graf wrote:
> > + static const u32 msrpm_offsets[] = {
> > + 0x0000002c, /* SYSENTER_CS */
> > +
> > + 0x00000038, /* LASTBRANCHFROMIP
> > + LASTBRANCHTOIP
> > + LASTINTFROMIP
> > + LASTINTTOIP */
> > +
> > + 0x00000820, /* STAR
> > + LSTAR
> > + CSTAR
> > + SYSCALL_MASK */
> > +
> > + 0x00000840, /* FS_BASE
> > + GS_BASE
> > + KERNEL_GS_BASE */
> > +
> > + 0xffffffff, /* End of List */
>
> Isn't there such a list around somewhere already? We really should
> only keep this list once throughout the whole code. If necessary, just
> create the list on the fly when bits get set in the msrpm.

No, the list is hardcoded in 3 functions (as parameter of
set_msr_interception). I think about a variant to do this with a single
list. Probably I create a list of MSRs and check in
set_msr_interceptionm for it.

Joerg