From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: [patch 4/7] kvm-tpr-opt: clean up usage of bios_enabled Date: Mon, 08 Mar 2010 21:47:08 -0300 Message-ID: <20100309004834.722887121@redhat.com> References: <20100309004704.049355766@redhat.com> Cc: Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43744 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756235Ab0CIAt2 (ORCPT ); Mon, 8 Mar 2010 19:49:28 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o290nS23020697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Mar 2010 19:49:28 -0500 Content-Disposition: inline; filename=kvm-tpr-bios-enabled-clean Sender: kvm-owner@vger.kernel.org List-ID: 1. bios_enabled must already be set when enable_vapic is called. 2. kvm_tpr_vcpu_start is called during vcpu creation, when bios_enabled is always zero. Signed-off-by: Marcelo Tosatti Index: qemu-kvm-tpr/kvm-tpr-opt.c =================================================================== --- qemu-kvm-tpr.orig/kvm-tpr-opt.c +++ qemu-kvm-tpr/kvm-tpr-opt.c @@ -250,7 +250,6 @@ int kvm_tpr_enable_vapic(CPUState *env) static int enable_vapic(CPUState *env) { - bios_enabled = 1; env->update_vapic = 1; return 1; } @@ -322,8 +321,6 @@ void kvm_tpr_access_report(CPUState *env void kvm_tpr_vcpu_start(CPUState *env) { kvm_enable_tpr_access_reporting(env); - if (bios_enabled) - kvm_tpr_enable_vapic(env); } static void tpr_save(QEMUFile *f, void *s)