From: Christoph Hellwig <hch@infradead.org>
To: Avi Kivity <avi@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
Bernhard Schmidt <berni@birkenwald.de>,
kvm@vger.kernel.org
Subject: Re: linux-aio usable?
Date: Tue, 9 Mar 2010 09:12:33 -0500 [thread overview]
Message-ID: <20100309141233.GA27443@infradead.org> (raw)
In-Reply-To: <4B961D7D.20107@redhat.com>
On Tue, Mar 09, 2010 at 12:05:49PM +0200, Avi Kivity wrote:
>> http://thread.gmane.org/gmane.linux.kernel.aio.general/2891
>>
>> It's missing compat_ioctl for some of the aio opcodes, namely
>> it's PREADV and PWRITE - the only ones used by kvm and the only
>> ones missing in kernel.
>>
>> As far as i can see, current code converts the iocb array just
>> fine, but does not touch iovec array used with p{read,write}v.
>>
>
> Yikes, looks pretty bad.
No need for compat_ioctl handlers as there are no ioctls involved
in aio, we just need better compat versions of io_submit, which
by itself is a bit of an ioctl-like multiplexer.
Adding the vector compat might be a bit messy, but shouldn't be
too hard given that we already deal with this for native
(p)readv/(p)writev.
next prev parent reply other threads:[~2010-03-09 14:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 1:46 linux-aio usable? Bernhard Schmidt
2010-03-08 9:10 ` Avi Kivity
2010-03-08 9:48 ` Bernhard Schmidt
2010-03-08 9:48 ` Avi Kivity
2010-03-08 14:25 ` Dustin Kirkland
2010-03-08 14:26 ` Avi Kivity
2010-03-08 16:28 ` Anthony Liguori
2010-03-08 16:36 ` Avi Kivity
2010-03-08 13:00 ` Christoph Hellwig
2010-03-08 20:11 ` Michael Tokarev
2010-03-08 20:19 ` Michael Tokarev
2010-03-09 9:08 ` Avi Kivity
2010-03-09 9:19 ` Michael Tokarev
2010-03-09 10:05 ` Avi Kivity
2010-03-09 14:12 ` Christoph Hellwig [this message]
2010-03-08 21:27 ` Nikola Ciprich
2010-03-08 21:46 ` Brian Jackson
2010-03-09 9:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309141233.GA27443@infradead.org \
--to=hch@infradead.org \
--cc=avi@redhat.com \
--cc=berni@birkenwald.de \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox