From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 02/18] KVM: MMU: Make tdp_enabled a mmu-context parameter Date: Wed, 10 Mar 2010 15:44:27 +0100 Message-ID: <20100310144426.GK5619@amd.com> References: <1267643541-451-1-git-send-email-joerg.roedel@amd.com> <1267643541-451-3-git-send-email-joerg.roedel@amd.com> <4B94C0B5.7080507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Avi Kivity Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:28391 "EHLO TX2EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756610Ab0CJOom (ORCPT ); Wed, 10 Mar 2010 09:44:42 -0500 Content-Disposition: inline In-Reply-To: <4B94C0B5.7080507@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Mar 08, 2010 at 11:17:41AM +0200, Avi Kivity wrote: > On 03/03/2010 09:12 PM, Joerg Roedel wrote: > >This patch changes the tdp_enabled flag from its global > >meaning to the mmu-context. This is necessary for Nested SVM > >with emulation of Nested Paging where we need an extra MMU > >context to shadow the Nested Nested Page Table. > > > > > >diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > >index ec891a2..e7bef19 100644 > >--- a/arch/x86/include/asm/kvm_host.h > >+++ b/arch/x86/include/asm/kvm_host.h > >@@ -254,6 +254,7 @@ struct kvm_mmu { > > int root_level; > > int shadow_root_level; > > union kvm_mmu_page_role base_role; > >+ bool tdp_enabled; > > > > This needs a different name, since the old one is still around. > Perhaps we could call it parent_mmu and make it a kvm_mmu pointer. Hmm, how about renaming the global tdp_enabled variable to tdp_usable? The global variable indicates if tdp is _usable_ and we can _enable_ it for a mmu context. Joerg