From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 1/3] target-i386: print EFER in cpu_dump_state
Date: Thu, 11 Mar 2010 15:53:23 -0300
Message-ID: <20100311185323.GC17264@amt.cnet>
References: <20100309015343.901738854@redhat.com>
 <20100309015644.133975091@redhat.com>
 <4B98AB49.4030209@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:7021 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755499Ab0CKTJQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 11 Mar 2010 14:09:16 -0500
Content-Disposition: inline
In-Reply-To: <4B98AB49.4030209@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Mar 11, 2010 at 10:35:21AM +0200, Avi Kivity wrote:
> On 03/09/2010 03:53 AM, Marcelo Tosatti wrote:
> >Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
> >
> >Index: qemu-kvm-uq/target-i386/helper.c
> >===================================================================
> >--- qemu-kvm-uq.orig/target-i386/helper.c
> >+++ qemu-kvm-uq/target-i386/helper.c
> >@@ -1176,6 +1176,7 @@ void cpu_dump_state(CPUState *env, FILE
> >      cpu_x86_dump_seg_cache(env, f, cpu_fprintf, "TR",&env->tr);
> >
> >  #ifdef TARGET_X86_64
> >+    cpu_fprintf(f, "EFER=    %016" PRIx64 "\n", env->efer);
> >      if (env->hflags&  HF_LMA_MASK) {
> >          cpu_fprintf(f, "GDT=     %016" PRIx64 " %08x\n",
> >                      env->gdt.base, env->gdt.limit);
> >
> 
> Better to do this for i386 too, no?

"On systems that support IA-32e mode, the extended feature enable
register (IA32_EFER) is available. This model-specific register controls
activation of IA-32e mode and other IA-32e mode operations."

Can it be useful for i386 too?