From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH 05/10] Don't call apic functions directly from kvm code
Date: Wed, 17 Mar 2010 11:00:22 -0300 [thread overview]
Message-ID: <20100317140022.GA9951@mothafucka.localdomain> (raw)
In-Reply-To: <4B964CA6.9050909@redhat.com>
On Tue, Mar 09, 2010 at 03:27:02PM +0200, Avi Kivity wrote:
> On 02/26/2010 10:12 PM, Glauber Costa wrote:
> >It is actually not necessary to call a tpr function to save and load cr8,
> >as cr8 is part of the processor state, and thus, it is much easier
> >to just add it to CPUState.
> >
> >As for apic base, wrap kvm usages, so we can call either the qemu device,
> >or the in kernel version.
> >
> >
> > }
> >
> >+static void kvm_set_apic_base(CPUState *env, uint64_t val)
> >+{
> >+ if (!kvm_irqchip_in_kernel())
> >+ cpu_set_apic_base(env, val);
>
> What if it is in kernel? Just ignored? Doesn't seem right.
At this point it is right, because there is no irqchip in kernel yet.
In a later patch, irqchip in kernel begins to exist, and this function
gets filled.
next prev parent reply other threads:[~2010-03-17 14:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 20:12 [PATCH 00/10] uq/master: irqchip-in-kernel support Glauber Costa
2010-02-26 20:12 ` [PATCH 01/10] introduce VMSTATE_U64 Glauber Costa
2010-02-26 20:12 ` [PATCH 02/10] Provide ioapic-kvm Glauber Costa
2010-02-26 20:12 ` [PATCH 03/10] provide apic_set_irq_delivered Glauber Costa
2010-02-26 20:12 ` [PATCH 04/10] provide i8259-kvm Glauber Costa
2010-02-26 20:12 ` [PATCH 05/10] Don't call apic functions directly from kvm code Glauber Costa
2010-02-26 20:12 ` [PATCH 06/10] export kvm_put_mp_state Glauber Costa
2010-02-26 20:12 ` [PATCH 07/10] provide apic-kvm Glauber Costa
2010-02-26 20:12 ` [PATCH 08/10] Add -kvm option Glauber Costa
2010-02-26 20:12 ` [PATCH 09/10] Initialize in-kernel irqchip Glauber Costa
2010-02-26 20:12 ` [PATCH 10/10] Do GSI routing Glauber Costa
2010-03-02 4:31 ` [PATCH 09/10] Initialize in-kernel irqchip Marcelo Tosatti
2010-03-02 18:25 ` Glauber Costa
2010-03-09 13:21 ` Avi Kivity
2010-02-27 10:35 ` [PATCH 08/10] Add -kvm option Jan Kiszka
2010-03-04 16:20 ` Jan Kiszka
2010-03-04 19:39 ` Glauber Costa
2010-03-02 4:31 ` Marcelo Tosatti
2010-03-02 18:25 ` Glauber Costa
2010-03-04 19:41 ` Anthony Liguori
2010-03-04 19:38 ` Anthony Liguori
2010-03-04 16:49 ` [PATCH 07/10] provide apic-kvm Jan Kiszka
2010-03-09 13:27 ` [PATCH 05/10] Don't call apic functions directly from kvm code Avi Kivity
2010-03-17 14:00 ` Glauber Costa [this message]
2010-03-17 16:29 ` Avi Kivity
2010-03-02 4:28 ` [PATCH 02/10] Provide ioapic-kvm Marcelo Tosatti
2010-03-02 18:26 ` Glauber Costa
2010-02-27 10:28 ` [PATCH 00/10] uq/master: irqchip-in-kernel support Jan Kiszka
2010-03-01 15:19 ` Marcelo Tosatti
2010-03-04 16:33 ` Jan Kiszka
2010-03-08 20:56 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317140022.GA9951@mothafucka.localdomain \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox