From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH rework] KVM: coalesced_mmio: fix kvm_coalesced_mmio_init()'s error handling Date: Wed, 17 Mar 2010 16:08:05 -0300 Message-ID: <20100317190805.GA12565@amt.cnet> References: <20100315221330.76e7d7d3.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4890 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755322Ab0CQTT7 (ORCPT ); Wed, 17 Mar 2010 15:19:59 -0400 Content-Disposition: inline In-Reply-To: <20100315221330.76e7d7d3.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Mar 15, 2010 at 10:13:30PM +0900, Takuya Yoshikawa wrote: > kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced > mmio ring page and dev even after it has freed them. > > Also, if this function fails, though it might be rare, it seems to be > suggesting the system's serious state: so we'd better stop the works > following the kvm_creat_vm(). > > This patch clears these problems. > > We move the coalesced mmio's initialization out of kvm_create_vm(). > This seems to be natural because it includes a registration which > can be done only when vm is successfully created. > > Signed-off-by: Takuya Yoshikawa > --- > virt/kvm/coalesced_mmio.c | 2 ++ > virt/kvm/kvm_main.c | 12 ++++++++---- > 2 files changed, 10 insertions(+), 4 deletions(-) Applied, thanks.