Re: [RFC] Unify KVM kernel-space and user-space code into a single project

Anthony Liguori
2010-03-22T22:06:17Z

On 03/22/2010 02:47 PM, Avi Kivity wrote:
> On 03/22/2010 09:27 PM, Ingo Molnar wrote:
>>
>>> If your position basically boils down to, we can't trust userspace
>>> and we can always trust the kernel, I want to eliminate any
>>> userspace path, then I can't really help you out.
>> Why would you want to 'help me out'? I can tell a good solution from
>> a bad one
>> just fine.
>
> You are basically making a kernel implementation a requirement,
> instead of something that follows from the requirement.
>
>> You should instead read the long list of disadvantages above, invert
>> them and
>> list then as advantages for the kernel-based vcpu enumeration
>> solution, apply
>> common sense and go admit to yourself that indeed in this situation a
>> kernel
>> provided enumeration of vcpu contexts is the most robust solution.
>
> Having qemu enumerate guests one way or another is not a good idea IMO
> since it is focused on one guest and doesn't have a system-wide entity.

There always needs to be a system wide entity. There are two ways to
enumerate instances from that system wide entity. You can centralize
the creation of instances and there by maintain an list of current
instances. You can also allow instances to be created in a
decentralized manner and provide a standard mechanism for instances to
register themselves with the system wide entity.

IOW, it's the difference between asking libvirtd to exec(qemu) vs
allowing a user to exec(qemu) and having qemu connect to a well known
unix domain socket for libvirt to tell libvirtd that it exists.

The later approach has a number of advantages. libvirt already supports
both models. The former is the '/system' uri and the later is the
'/session' uri.

What I'm proposing, is to use the host file system as the system wide
entity instead of libvirtd. libvirtd can monitor the host file system
to participate in these activities but ultimately, moving this
functionality out of libvirtd means that it becomes the standard
mechanism for all qemu instances regardless of how they're launched.

Regards,

Anthony Liguori

> A userspace system-wide entity will work just as well as kernel
> implementation, without its disadvantages.
>